Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StartCreateProposal in parallel #173

Closed
SamYuan1990 opened this issue Apr 10, 2021 · 0 comments · Fixed by #194 or #208
Closed

Support StartCreateProposal in parallel #173

SamYuan1990 opened this issue Apr 10, 2021 · 0 comments · Fixed by #194 or #208
Assignees
Labels
MergeInComing Merge Into Main In Next Release pinned Pin this issue to prevent from auto-closing

Comments

@SamYuan1990
Copy link
Member

Is your proposal related to a problem?

N/A

(Write your answer here.)

Describe the solution you'd like

Currently we have single create proposal. As below:

	go StartCreateProposal(num, burst, rate, config, crypto, raw, errorCh, logger)

and we have 5 signer etc.

	for i := 0; i < 5; i++ {
		go assember.StartSigner(raw, signed, errorCh, done)
		go assember.StartIntegrator(processed, envs, errorCh, done)
	}

(Describe your proposed solution here.)

Describe alternatives you've considered

change to k and make k as user input optional parameter?

	for i := 0; i < k; i++ {
		go assember.StartSigner(raw, signed, errorCh, done)
		go assember.StartIntegrator(processed, envs, errorCh, done)
        	go StartCreateProposal(num, burst, rate, config, crypto, raw, errorCh, logger)
      }

Additional context

consider we have limited network I/O as max connection number for peer, and peer is able to deal with more request.
by this change, we are able to send more Proposal to peer.

@SamYuan1990 SamYuan1990 added the pinned Pin this issue to prevent from auto-closing label Apr 10, 2021
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Aug 5, 2021
SamYuan1990 added a commit that referenced this issue Aug 5, 2021
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Aug 24, 2021
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Aug 24, 2021
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Aug 24, 2021
@SamYuan1990 SamYuan1990 self-assigned this Aug 24, 2021
@SamYuan1990 SamYuan1990 mentioned this issue Aug 31, 2021
@SamYuan1990 SamYuan1990 added the MergeInComing Merge Into Main In Next Release label Oct 31, 2021
davidkhala pushed a commit that referenced this issue Mar 23, 2022
davidkhala pushed a commit that referenced this issue Mar 23, 2022
* 109 to alpha (#189)

* 1st impl for #109

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* Arch refactor alpha (#190)

* add crpto interface as repare for #127

Signed-off-by: Sam Yuan <[email protected]>

* adding Worker interface for #56 and decouple Assembler and Integrator

Signed-off-by: Sam Yuan <[email protected]>

* refactor for worker interface

Signed-off-by: Sam Yuan <[email protected]>

* package structure

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* package refactor

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* remove Envelope from elements

Signed-off-by: Sam Yuan <[email protected]>

* add memeory free

Signed-off-by: Sam Yuan <[email protected]>

* remove Proposal from Elements

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* move start time to ctx

Signed-off-by: Sam Yuan <[email protected]>

* fix up for time setting (#191)

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* impl for #173 supports for configurable signers in parallel (#194)

Signed-off-by: Sam Yuan <[email protected]>

* adding for commit phase only dummy impl (#195)

* adding for commit phase only dummy impl

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* impl for endorsement only

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* update document and prepare for release (#196)

* update document and prepare for release

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up in readme (#197)

Signed-off-by: Sam Yuan <[email protected]>

* impl for #200 (#207)

Signed-off-by: Sam Yuan <[email protected]>

* Impl173 (#208)

* adjust code

Signed-off-by: Sam Yuan <[email protected]>

* code refactor

Signed-off-by: Sam Yuan <[email protected]>

* code refactor

Signed-off-by: Sam Yuan <[email protected]>

* use const instead

Signed-off-by: Sam Yuan <[email protected]>

* adding parallel flag

Signed-off-by: Sam Yuan <[email protected]>

* try to check escapes in ci (#209)

* try to check escapes in ci

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* add benchmark test and adjust regex impl solution

Signed-off-by: Sam Yuan <[email protected]>

* attempt

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* 174 (#210)

* use kingpin global flag and adding test case with timeout command

Signed-off-by: Sam Yuan <[email protected]>

* impl for #174

Signed-off-by: Sam Yuan <[email protected]>

* adding test case

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* add signal listening

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* adding patch for #174 (#211)

* adding patch for #174

Signed-off-by: Sam Yuan <[email protected]>

* bug fix

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* impl for #213 (#214)

* impl for #213

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* add orderer observer into full workflow process (#216)

* add orderer observer into full workflow process

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* impl for txid tracing at traffic generate (#218)

* impl for txid tracing at traffic generate

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* try to add tx tracing for observer (#219)

Signed-off-by: Sam Yuan <[email protected]>

* nit fix (#220)

Signed-off-by: Sam Yuan <[email protected]>

* Nitfix for date format (#221)

* use RFC3339Nano

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* impl for #223 (#225)

* impl for #223

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up (#226)

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up (#227)

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up delete map to avoid OOM (#228)

Signed-off-by: Sam Yuan <[email protected]>

* update for git doc (#235)

Signed-off-by: Sam Yuan <[email protected]>

* impl for policy support (#237)

* add plan

Signed-off-by: Sam Yuan <[email protected]>

* update ginkgo and add test for policy impl

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* try to impl with policy support

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>

* fix up

Signed-off-by: Sam Yuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MergeInComing Merge Into Main In Next Release pinned Pin this issue to prevent from auto-closing
1 participant