Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-25] update vllm install process, improve vllm benchmark test #2

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

mino-park7
Copy link

  • vLLM editable mode installation script 추가
    • VLLM_TARGET_DEVICE에 fpga 추가하여, C extension 설치하지 않도록 수정
  • cleanup() 관련 bug 수정
  • examples/mini_testbench.sh 고도화
    • long context, multi request case 테스트하도록 변경
    • 중간에 error 발생 시, fail 되도록 수정

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

- Introduced `hyperdex_install.sh` for setting up Hyperdex dependencies.
- Added `requirements-fpga.txt` to specify common and Hyperdex dependencies for FPGA.
- Updated `MANIFEST.in` to include `requirements-fpga.txt`.
- Enhanced `setup.py` to support FPGA as a target device, modifying build logic and requirements retrieval accordingly.
- Changed default prompt in `lpu_client.py`, `lpu_inference_arg.py`, and `lpu_inference.py` to long context
- Improved `mini_testbench.sh` to handle multiple requests and added error checking for Python script execution.
- Updated logging to include timestamps in directory names for better organization of output logs.
@mino-park7 mino-park7 added bug Something isn't working enhancement New feature or request labels Jan 21, 2025
@mino-park7 mino-park7 self-assigned this Jan 21, 2025
Copy link

@opus24 opus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llm_engine.py는 수정할 필요가 없습니다. 현재는 서빙 시스템을 열 때 --disable_frontend_multiprocessing 옵션을 추가해야하고, 해당옵션없이 동작 가능하도록 수정하겠습니다.

@mino-park7
Copy link
Author

llm_engine.py는 수정할 필요가 없습니다. 현재는 서빙 시스템을 열 때 --disable_frontend_multiprocessing 옵션을 추가해야하고, 해당옵션없이 동작 가능하도록 수정하겠습니다.

아 넵 그러면 이 브랜치에 작업한 것 올려서 같이 merge하시죠

…vironment

- Translated and expanded the README_LPU.md to provide comprehensive installation guides for both Conda and Pip methods, including specific commands for setting up Hyperdex packages and vLLM.
- Updated `mini_testbench.sh` and `vllm_serve.sh` scripts to use the new `vllm serve` command for starting the API server, replacing the previous method for better clarity and functionality.
- Add a guide for using `vllm serve` that must use a
`--disable-frontend-multiprocessing` option
@mino-park7 mino-park7 requested a review from opus24 January 22, 2025 02:08
Copy link

@opus24 opus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인드립니다!

@mino-park7 mino-park7 merged commit f9af0bf into feature/lpu-backend Jan 22, 2025
@mino-park7 mino-park7 deleted the SW-25-update-vllm-install-process branch January 22, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants