-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SW-25] update vllm install process, improve vllm benchmark test #2
[SW-25] update vllm install process, improve vllm benchmark test #2
Conversation
- Introduced `hyperdex_install.sh` for setting up Hyperdex dependencies. - Added `requirements-fpga.txt` to specify common and Hyperdex dependencies for FPGA. - Updated `MANIFEST.in` to include `requirements-fpga.txt`. - Enhanced `setup.py` to support FPGA as a target device, modifying build logic and requirements retrieval accordingly.
- Changed default prompt in `lpu_client.py`, `lpu_inference_arg.py`, and `lpu_inference.py` to long context - Improved `mini_testbench.sh` to handle multiple requests and added error checking for Python script execution. - Updated logging to include timestamps in directory names for better organization of output logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llm_engine.py는 수정할 필요가 없습니다. 현재는 서빙 시스템을 열 때 --disable_frontend_multiprocessing 옵션을 추가해야하고, 해당옵션없이 동작 가능하도록 수정하겠습니다.
아 넵 그러면 이 브랜치에 작업한 것 올려서 같이 merge하시죠 |
… class" This reverts commit e6d9d12.
…vironment - Translated and expanded the README_LPU.md to provide comprehensive installation guides for both Conda and Pip methods, including specific commands for setting up Hyperdex packages and vLLM. - Updated `mini_testbench.sh` and `vllm_serve.sh` scripts to use the new `vllm serve` command for starting the API server, replacing the previous method for better clarity and functionality. - Add a guide for using `vllm serve` that must use a `--disable-frontend-multiprocessing` option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
승인드립니다!
cleanup()
관련 bug 수정examples/mini_testbench.sh
고도화BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!