Remove empty()

HypeMC · May 13, 2022 · 71cba11 · 71cba11
1 parent 2fb12f5
commit 71cba11
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/ConfigurationProvider/AbstractConfigurationProvider.php b/src/ConfigurationProvider/AbstractConfigurationProvider.php
@@ -22,7 +22,7 @@ protected static function mergeConfigurations(array $firstConfiguration, array $
 
         $firstConfiguration += $secondConfiguration;
 
-        if (!empty($extraOptions)) {
+        if ($extraOptions) {
             $firstConfiguration['extra_options'] = $extraOptions;
         }
 

diff --git a/src/ConfigurationProvider/AnnotationConfigurationProvider.php b/src/ConfigurationProvider/AnnotationConfigurationProvider.php
@@ -43,6 +43,6 @@ public function __invoke(LoggableOutputInterface $loggableOutput): array
             $configuration = self::mergeConfigurations($configuration, $annotation->getOptions());
         } while (false !== $reflection = $reflection->getParentClass());
 
-        return empty($configuration) ? $configuration : $this->containerBag->resolveValue($configuration);
+        return $configuration ? $this->containerBag->resolveValue($configuration) : $configuration;
     }
 }
diff --git a/src/ConfigurationProvider/AttributeConfigurationProvider.php b/src/ConfigurationProvider/AttributeConfigurationProvider.php
@@ -38,6 +38,6 @@ public function __invoke(LoggableOutputInterface $loggableOutput): array
             $configuration = self::mergeConfigurations($configuration, $attribute->getOptions());
         } while (false !== $reflectionObject = $reflectionObject->getParentClass());
 
-        return empty($configuration) ? $configuration : $this->containerBag->resolveValue($configuration);
+        return $configuration ? $this->containerBag->resolveValue($configuration) : $configuration;
     }
 }
diff --git a/src/ConfigurationProvider/MergedConfigurationProvider.php b/src/ConfigurationProvider/MergedConfigurationProvider.php
@@ -23,7 +23,7 @@ public function __invoke(LoggableOutputInterface $loggableOutput): array
         $mergedConfiguration = [];
 
         foreach ($this->configurationProviders as $configurationProvider) {
-            if ([] !== $configuration = $configurationProvider($loggableOutput)) {
+            if ($configuration = $configurationProvider($loggableOutput)) {
                 $mergedConfiguration = self::mergeConfigurations($mergedConfiguration, $configuration);
             }
         }