-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UC of partial collection #165
Conversation
// do something with the _member_, i.e. display it | ||
} | ||
// load some more on demand | ||
data = client.get(data.next); | ||
for (const member of data.members) { | ||
collection = client.get(data.view[0].next); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alien-mcl Maybe this snippet could already use the new API as proposed in HydraCG/Heracles.ts#34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea. I'll try to update that PR with API "release candidate" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am correct we have also replaced get
method with getResource
. If no one is working on this then I would like to create a PR adapting use cases to new client API.
@lanthaler, do we still keep the second {
"totalItems": 100, // total
"view": [{
"items": 10 // this page/view
}]
} |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. drafts/use-cases/3.2.pagination.md, line 26 at r1 (raw file): Previously, alien-mcl (Karol Szczepański) wrote…
Yeah, just calling Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
Closing as we no longer have maintain these use case document in this repo. |
Fixes #163
I've updated the example of a partial collection to be represented using the
PartialCollectionView
as agreed in #42.This change is