Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new command to withdraw banned funds #80

Merged

Conversation

Vitomir2
Copy link
Contributor

Description

  • create a new helper function to create transactions;
  • polish the codebase for the commands to follow the same template;
  • update the submodules to get the latest contracts abis;
  • generate new artifacts and bind the new binding for the withdrawBannedFunds function;
  • add a new flag to the current withdraw command to indicate when to withdraw normally and when to withdraw banned funds;
  • implement the functionality for the withdrawal of the banned funds;
  • add the withdraw banned funds and claim-rewards commands in the docs;

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

I have configured a fresh local chain and tested if all commands work fine after the polish and if the new withdraw banned funds work.

create a new helper function to create transactions;
polish the codebase for the commands to follow the same template;
update the submodules to get the latest contracts abis;
generate new artifacts and bind the new binding for the withdrawBannedFunds function;
add a new flag to the current withdraw command to indicate when to withdraw normally and when to withdraw banned funds;
implement the functionality for the withdrawal of the banned funds;
add the withdraw banned funds and claim-rewards commands in the docs;
@Vitomir2 Vitomir2 added the enhancement New feature or request label Nov 18, 2024
@Vitomir2 Vitomir2 requested a review from R-Santev November 18, 2024 07:52
@Vitomir2 Vitomir2 merged commit ac19313 into develop Nov 20, 2024
5 checks passed
@Vitomir2 Vitomir2 deleted the 272-add-a-command-to-withdraw-banned-funds-in-the-node branch November 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants