279 voting power is not synced properly on start of epoch #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Santev
requested changes
Nov 13, 2024
R-Santev
approved these changes
Nov 15, 2024
use epoch.Validators.Copy() in order to ensure that the validators are not passed by reference and updated in some of the next functions; optimize if conditions for the end and start of epoch; get the validators from the last epoch; update the implementation for the generation of the syncValidatorsData input to properly extract the removed validators, too;
delete the .Copy() as discussed with Roskata; update the ExtractUpdatedValidatorsVotingPower logic to loop through the added, updated and then check removed validators; avoid setting the VotingPower to 0 and add it as a parameter of the formatValidatorPower function; create new test function createTestExtraForSyncValidatorsData and use it for the extraData; make one test that includes added, updated and removed validators; set concrete params instead of mock.Anything in the GetValidators mock;
Vitomir2
force-pushed
the
279-voting-power-is-not-synced-properly-on-start-of-epoch
branch
from
1adf537 to
2e889e4
Compare
Vitomir2
deleted the
279-voting-power-is-not-synced-properly-on-start-of-epoch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
epoch.Validators.Copy()on creatingNewValidatorSetin order to avoid redundant operations;syncValidatorsDatainput to properly extract the removed validators, too;createTestExtraForSyncValidatorsDatafunction;Changes include
Checklist
Testing
Manual tests
I have configured the blockchain locally and have tested if the syncValidatorsData's input is generated correctly and it seems all work fine. Additionally, added some tests to ensure that the extract function works properly.