Price oracle #36
Merged
Price oracle #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure the secrets retrieve from the secretsManagerConfig.json; add the secrets generation in the docs; create new functions to fetch price from coingecko and coinmarketcap; create functions that help to achieve our goal; adapt functions and format the codebase;
update the core-contracts module from the commit with the Price Oracle implementation and also add some local changes temporarily; configure prerequisites for and deploy the new PriceOracle contract; create a function to format the URL for the JSON-RPC; configure the txRelayer and execute the required transactions; finalize the shouldVote function; print the result from the vote;
…s://github.com/Hydra-Chain/hydragon-node into 184-implement-pricefetcher-service-in-the-node # Conflicts: # price-oracle/price_oracle_test.go
…ce-in-the-node' into 184-implement-pricefetcher-service-in-the-node # Conflicts: # price-oracle/price_oracle_test.go
Vitomir2
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
To me it LGTM. One thing that I have noticed is that the calcDayNumber is called multiple times in the whole process of the handleEvent method. I suppose it is made by purpose, in order to not open the functions to vulnerabilities by passing it as an argument, right? @R-Santev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182 and #184