168 integrate rewardwallet in node and fulfill at the end of every epoch #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update core-contracts submodule and compile; generate artifacts and bindings; delete redundant space in the submodules command;
remove the reward calculator logic and the distribution of the actual HYDRA with distributeRewardsFor function execution; add a constant rewardWallet address, generate artifacts and bindings; configure RewardPool address and initialize it;
initialize the new fsm fundRewardWallet property in the consensus_runtime; create a new function to verify the fund reward wallet function; update the decode state tx method to allow empty input methods; implement the function to check the current balance, if so, then calculate the remaining amount to 2/3 maxuint; create a new function in the blokchain wrapper which get the balance of a given account using the transition object; adapt some tests and add new ones;
check the input args for len() == 0, instead of the inputs as a whole, because it counts the signature, too and tests were failing; clean up the codebase;
check the input args for len() == 0, instead of the inputs as a whole, because it counts the signature, too and tests were failing; checkout the core-contracts to a specific commit and adapt tests; clean up the codebase;
Vitomir2
force-pushed
the
168-integrate-rewardwallet-in-node-and-fulfill-at-the-end-of-every-epoch
branch
from
aa70542 to
4cdae61
Compare
R-Santev
requested changes
Jul 29, 2024
add err message that will be thrown for missing fund reward wallet tx; check if there is need for funding of the reward wallet, if so, check that the transaction exists on the end of epoch; add new test to cover the error;
R-Santev
approved these changes
Jul 31, 2024
Vitomir2
deleted the
168-integrate-rewardwallet-in-node-and-fulfill-at-the-end-of-every-epoch
branch
Vitomir2
restored the
168-integrate-rewardwallet-in-node-and-fulfill-at-the-end-of-every-epoch
branch
Vitomir2
deleted the
168-integrate-rewardwallet-in-node-and-fulfill-at-the-end-of-every-epoch
branch
R-Santev
pushed a commit
that referenced
this pull request
Aug 2, 2024
* apply patch * Fix for unit tests * lint fix * lint fix * contracts fix * makefile fix * build fix * fix some imports * Lint fix * comment fixs * fix imports * Update command/genesis/genesis.go Co-authored-by: Stefan Negovanović <[email protected]> * Update command/genesis/params.go Co-authored-by: Stefan Negovanović <[email protected]> * fix comments * Linter fixes * deleted supernet package * stake fix * stake fix 2 * comments fix * Use new version of contracts * Remove RewardPool address and rename ValidatorSet address to EpochManager address * Remove burn contract flag * Remove non-mintable configuration in genesis * Lint fixes * Minor rename * Update e2e-polybft/e2e/consensus_test.go Co-authored-by: Stefan Negovanović <[email protected]> * Fix comment * bridge commands relocation (#19) * bridge commands relocation * mint command relocation * un/stake and whitelist from sidechain to validator folder * sidechain commands relocation * commands relocation * deleted license * build fix * Build fix * segmentation fault fix * added nativeERC20 approve * command fix --------- Co-authored-by: Stefan Negovanović <[email protected]> * Remove IsMintable native token flag (#22) * Remove IsMintable native token flag * Remove key from PremineInfo * Add blade admin flag (#24) * Introduce blade admin * Move to the newest main branch on contracts * Remove NativeTokenConfig from e2e tests * Comments fix --------- Co-authored-by: Goran Rojovic <[email protected]> * UT fix (#25) * Add default premine for validators (#26) * Fix consensus `e2e` tests (#28) * Fix e2e tests * Fix migration e2e test (#30) * Remove StakeManagerAddr, StakeTokenAddr and CustomSupernetManagerAddr from bridge config * Fix integration test (#31) * Fix fund command UT * Small fixes --------- Co-authored-by: Stefan Negovanović <[email protected]> * Small fixes for e2e tests * Move and modify `ChangeVotingPower` `e2e` test (#34) * Move and modify test * variable name change --------- Co-authored-by: Dusan <[email protected]> * Fix bridge e2e tests (#33) * Spin up bridge in bridge e2e tests * Remove unused param * Check if bridge is enabled when creating state sync relayer * Remove bridge non native ERC20 token test case * Logs * Fix segmentation fault * Remove logs * small fix * small fix * Deploy root erc20 token to the rootchain * Initialize CheckpointManager * Reduce default stake amount * TestE2E_Bridge_Transfers_AccessLists fix * Minor fixes * Fix TestE2E_AddressLists_Bridge * Fix TestE2E_Bridge_ERC721Transfer and TestE2E_Bridge_ERC1155Transfer * Fix TestE2E_Bridge_RootchainTokensTransfers * Premine fix * Reduce DefaultStake --------- Co-authored-by: Goran Rojovic <[email protected]> * Fix local deployment scripts (#40) * Fix cluster script * Fix docker local deployment * Rename (rootchain to bridge in command outputs) * Minor change --------- Co-authored-by: Stefan Negovanović <[email protected]> * test fix * Remove unnecessary forks (#42) * Remove leftover * Use in-house built event tracker (#41) * Use ethernal's event tracker * Remove log * EventTracker config in one struct * Comments fix --------- Co-authored-by: Stefan Negovanović <[email protected]> * baseFeeConfig as condition for london fork (#43) * baseFeeConfig as condition for london fork * lint fix * comment fix * Update command/genesis/polybft_params.go Co-authored-by: Goran Rojovic <[email protected]> * deleted unnecessary if * e2e test fix * Linter fix * Add base-fee-config to e2e tests where needed * Add SetBaseFeeConfig to the legacy e2e framework * Remove leftover * Provide non-validator account as receiver of native tokens in TestE2E_Consensus_MintableERC20NativeToken --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Stefan Negovanović <[email protected]> --------- Co-authored-by: Stefan Negovanović <[email protected]> Co-authored-by: Stefan Negovanović <[email protected]> Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Goran Rojovic <[email protected]>
R-Santev
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Deploy Network * Add Permissions * Minor changes * Concurrency change * Destroy Network * Minor changes * Minor changes * Fix commit sha * Minor changes * Add Tests * Disable Tests temporarily * Nightly Build * Minor fixes * Big changes * Minor changes * Minor changes * Minor changes * Notification fixes * Notification changes * Minor changes * Permissions fixes * Minor changes * Notification changes * Minor changes * Display commit on notifications * Minor changes * Minor fixes * Logs notification fixes * Minor changes * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR
Get the latest stable commit of the core-contracts, integrate all the new implementations, clean up the codebase, and adapt the tests.
Changes include
Checklist
Testing
Manual tests
I have tested running the node locally and interacting with it using the remixide and metamask.