Make 1.0.2 release #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Internal rearragement of code * Improved code formatting * Improved file documentation
|
If this changes backwards compatibility I'd rather up the version to a major 2.xx. Haven't tested it yet but I will try to do so tonight or sometime tomorrow. |
|
No, it does not so the version should be fine. This just a new file distribution for the "old system". I found out that we can do a version which would be able to serve both "old" and "new system". That should be a 2.x.x The one breaking with the "old" system should be 3.x.x. The latter fits best with with MW 1.31+ I guess so there is still some time. |
|
Missed this completely. Could you test the new method Sam pr'd. I just merged it in. |
samwilson
suggested changes
Nov 5, 2017
| * | ||
| */ | ||
|
|
||
| class PurgeActionExtension{ |
There was a problem hiding this comment.
- Class name should match the filename.
- Space required before the brace.
| $skin->getRelevantTitle() : $skin->getTitle(); | ||
| if ( $title->getNamespace() !== NS_SPECIAL && $wgUser->isAllowed( 'purge' ) ) { | ||
| $action = $wgRequest->getText( 'action' ); | ||
| $content_actions['actions']['purge'] = array( |
There was a problem hiding this comment.
Short array syntax should be used.
|
1.0.2 is already out, thus abandoning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to switch to extension registration and refers to issue #3.