-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update tag value #573
Feature/update tag value #573
Conversation
M-m, @Hugovdberg I saw your use of |
I chose this implementation to allow for direct use of |
* add timeout option * kostil with import System
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution. This is a valuable addition to the package, as it was a widely requested feature. I have added a few comments for things I would like to see slightly different before merging. Also, don't forget to add yourself to the AUTHORS.rst as a contributor!
Hi,
there was a discussion with possible implementation: #498.
Then, @ldariva contribute with pr: https://github.com/Hugovdberg/PIconnect/pull/540/files but it still is opened and with some changes suggested.
Acknowledgment
PS.
It is better to review and merge after #572