Guard against this.drop not existing #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minichate
force-pushed
the
guard-drop-not-exists
branch
from
33b23b5 to
e9e0510
Compare
If the element gets destroyed before the handlers get removed there are exeptions thrown complaining about `el.classList`. This is because `destroy()` sets `this.drop` to `null`. A null-guard should protect against this case.
minichate
force-pushed
the
guard-drop-not-exists
branch
from
e9e0510 to
24023af
Compare
|
Wondering what the status of this pull request is? This looks like it would solve some problems we're currently having with Drop. |
|
@megasmack Looks to me like HubSpot isn't actively maintaining this repo anymore. We're just installing this from my fork at https://github.com/minichate/drop instead :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the element gets destroyed before the handlers get removed there are exceptions thrown complaining about
el.classList. This is becausedestroy()setsthis.droptonull.A null-guard should protect against this case.