-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set language when opening new editor #82
Conversation
add request and timing info into response document make response info into comments
@dakaraphi the code LGTM. However, I still want to discuss with you that do we give user the flexibility that user can view the response in |
@Huachao so are you simply asking to provide a user preference setting?
I added 2 additional pieces of information. The request url and response time. Do you want that included when in |
@dakaraphi that's what I mean, what do you think about it? And thanks for your PR |
@Huachao I added 2 new preferences. Let me know what you think. I do think setting the language adds a lot of power and makes the experience richer.
If vscode resolves microsoft/vscode#1800 it will make it even better :-) |
html: '<!-- ', | ||
css: '/* ' | ||
} | ||
return commentStyle[language] ? commentStyle[language] + REST_RESPONSE: ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space before :
package.json
Outdated
"rest-client.includeAdditionalInfoInResponse": { | ||
"type": "boolean", | ||
"default": false, | ||
"description": "Include additional information such as request URL and response time" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also indicate that this only works when previewing response in untitled document
@dakaraphi Merged, I will publish this change in next release. Thanks for your contribution 😄 |
microsoft/vscode#1800 looks resolved. |
@Download @dakaraphi thanks, I've changed to use the latest setTextDocumentLanguage API. |
@Download @dakaraphi I have published the new version 0.20.3 with this new |
The new feature is working great. Thanks!
After using this for a bit, I found a couple of things that improve my work.
Hopefully you can consider these changes. Thanks!