Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#194 [fix] firebase log event 로직 수정 #195

Merged
merged 1 commit into from
Feb 21, 2023
Merged

#194 [fix] firebase log event 로직 수정 #195

merged 1 commit into from
Feb 21, 2023

Conversation

KWY0218
Copy link
Member

@KWY0218 KWY0218 commented Feb 18, 2023

관련 이슈

작업한 내용

  • firebase log event 로직 수정

PR 포인트

  • 실수로 스크린 진입 시 쌓이는 로그를 debug 모드일 때에도 쌓이게 해놨네요. 그거 수정했습니다.

@KWY0218 KWY0218 added 원용🐉 원용이가 작업함! fix 수정 Pull Request🔥 풀리퀘 날림! labels Feb 18, 2023
@KWY0218 KWY0218 added this to the Hous 2차 릴리즈 milestone Feb 18, 2023
@KWY0218 KWY0218 requested a review from a team February 18, 2023 04:53
@KWY0218 KWY0218 self-assigned this Feb 18, 2023
murjune
murjune approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 뭐 LGTM이지

app/src/main/java/hous/release/android/util/HousLogEvent.kt
Firebase.analytics.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW) {
param(FirebaseAnalytics.Param.SCREEN_CLASS, screenClass)
param(FirebaseAnalytics.Param.SCREEN_NAME, screenName)
if (!BuildConfig.DEBUG) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ㅋㅋㅋㅋ

yjooooo
yjooooo approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@yjooooo yjooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏻👍🏻👍🏻

2zerozu
2zerozu approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@2zerozu 2zerozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

냠냠

@KWY0218 KWY0218 merged commit f8ac601 into develop Feb 21, 2023
@2zerozu 2zerozu deleted the feature/#194-fix-firebase-log-event branch February 24, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjooooo yjooooo yjooooo approved these changes

@2zerozu 2zerozu 2zerozu approved these changes

@murjune murjune murjune approved these changes

Assignees

@KWY0218 KWY0218

Labels
fix 수정 Pull Request🔥 풀리퀘 날림! 원용🐉 원용이가 작업함!
Projects
None yet
Milestone
Hous 2차 릴리즈
Development

Successfully merging this pull request may close these issues.

[fix] firebase log event 수정
4 participants
@KWY0218 @yjooooo @2zerozu @murjune