Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate unions #753

Merged
merged 6 commits into from
Dec 10, 2022
Merged

Paginate unions #753

merged 6 commits into from
Dec 10, 2022

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Dec 9, 2022 •
edited
Loading

Fixes n/a

This PR fixes a bug reported in #651 that prevented @paginate from being used on unions.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 93546ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 9:50PM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 9:50PM (UTC)

@AlecAivazis AlecAivazis mentioned this pull request Dec 9, 2022
Closed
@AlecAivazis AlecAivazis merged commit 27cdbb0 into main Dec 10, 2022
@AlecAivazis AlecAivazis deleted the paginate-unions branch December 10, 2022 05:59
gterras pushed a commit to gterras/houdini that referenced this pull request Dec 14, 2022
@AlecAivazis
Fix bug when using paginate on unions (HoudiniGraphql#753)
f1c6730 
* add failing test

* failing test

* check union types for ids when looking at paginate targets

* remove errant log

* treat artifacts the same way as unions if there isn't a globally defined key config

* add test for interfaces
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
@AlecAivazis @endigma
Fix bug when using paginate on unions (HoudiniGraphql#753)
c73df11 
* add failing test

* failing test

* check union types for ids when looking at paginate targets

* remove errant log

* treat artifacts the same way as unions if there isn't a globally defined key config

* add test for interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlecAivazis