Use override=True for config1 in adjust_config_by_multi_process_divid… #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er() Sometimes, those configurations are provided through commandline. In general, configurations provided through commandline will not be changed by config1(). However, for DDP training, even if these configurations are from commandline, we still need to change them.
QuantuMope
previously approved these changes
Dec 10, 2024
alf/config_util.py
Outdated
| override_all (bool): If True, the value of the config will be set regardless | ||
| of any pre-existing ``mutable`` or ``sole_init`` settings. This should | ||
| be used only when absolutely necessary (e.g., adjusting certain configs | ||
| such as mini_batch_size for DDP workers.).""" |
There was a problem hiding this comment.
Formatting Nit: Add a newline before """
QuantuMope
approved these changes
Dec 11, 2024
qiang-sean-liu
pushed a commit
that referenced
this pull request
Jan 14, 2025
#1714) * Use override=True for config1 in adjust_config_by_multi_process_divider() Sometimes, those configurations are provided through commandline. In general, configurations provided through commandline will not be changed by config1(). However, for DDP training, even if these configurations are from commandline, we still need to change them. * Fix doc-string format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er()
Sometimes, those configurations are provided through commandline. In general, configurations provided through commandline will not be changed by config1(). However, for DDP training, even if these configurations are from commandline, we still need to change them.