Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] group refactoring #69

Merged
merged 7 commits into from
Nov 27, 2023
Merged

[FEAT] group refactoring #69

merged 7 commits into from
Nov 27, 2023

Conversation

jinjoo-lab
Copy link
Collaborator

@jinjoo-lab jinjoo-lab commented Nov 26, 2023

추가/수정한 기능 설명

  1. Group Refactoring
  2. Make GroupRequest -> leaderId 제외 , 그룹을 만든 사람이 그룹장이 되도록 로직 변경
  3. GroupTest 추가

특이사항

check list

  • 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했나요?
  • 추가/수정사항을 설명했나요?

@jinjoo-lab jinjoo-lab requested a review from ohksj77 November 26, 2023 16:17
@ohksj77 ohksj77 added refactor 리팩토링 test 테스트 수행 labels Nov 26, 2023
Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했으! 저거 테스트 코멘트는 다음부터 코멘트대로 해도 될듯!

final Group saveGroup = groupRepository.save(group);

// then
assertThat(saveGroup.getGroupMembers().size()).isEqualTo(2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 assertThat(list).hasSize(2); 하면 더 쉽게 테스트 할 수 있어!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 확인

@jinjoo-lab jinjoo-lab force-pushed the feat/group-refactoring branch from 8b6aa0a to 42263ee Compare November 26, 2023 18:07
@jinjoo-lab jinjoo-lab force-pushed the feat/group-refactoring branch from 653a2f3 to 0a2ea16 Compare November 27, 2023 01:19
@ohksj77 ohksj77 changed the title Feat/group refactoring [FEAT] group refactoring Nov 27, 2023
@jinjoo-lab jinjoo-lab merged commit 6e50ec1 into master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 리팩토링 test 테스트 수행
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants