Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpr 1.5.2 #63160

Closed
wants to merge 2 commits into from
Closed

cpr 1.5.2 #63160

wants to merge 2 commits into from

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Oct 20, 2020

Created with brew bump-formula-pr.

chenrui333
chenrui333 previously approved these changes Oct 21, 2020
View reviewed changes
@chenrui333 chenrui333 dismissed their stale review October 21, 2020 22:42

audit failure

@chenrui333
Copy link
Member

audit failure

==> brew audit cpr --online --git --skip-style
==> FAILED
Error: 2 problems in 1 formula detected
cpr:
  * Files were found with references to the Homebrew shims directory.
    The offending files are:
      bin/curl-config
  * Header files that shadow system header files were installed to "/usr/local/opt/cpr/include"
    The offending files are:
      /usr/local/opt/cpr/include/curl/mprintf.h
            /usr/local/opt/cpr/include/curl/easy.h
            /usr/local/opt/cpr/include/curl/curl.h
            /usr/local/opt/cpr/include/curl/curlver.h
            /usr/local/opt/cpr/include/curl/system.h
            /usr/local/opt/cpr/include/curl/typecheck-gcc.h
            /usr/local/opt/cpr/include/curl/multi.h

@chenrui333 chenrui333 added the audit failure CI fails while auditing the software label Oct 23, 2020
@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Nov 26, 2020
@Rylan12 Rylan12 mentioned this pull request Nov 26, 2020
Merged
5 tasks
@BrewTestBot BrewTestBot removed the stale No recent activity label Nov 26, 2020
@bayandin bayandin removed the audit failure CI fails while auditing the software label Dec 8, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

chenrui333
chenrui333 reviewed Dec 8, 2020
View reviewed changes
Formula/cpr.rb
@@ -19,6 +19,15 @@ class Cpr < Formula

uses_from_macos "curl"

# Fix system curl detection
# See https://github.com/whoshuu/cpr/pull/428
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, not sure how I missed that 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 8, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@bayandin bayandin bayandin approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alebcay @chenrui333 @BrewTestBot @bayandin