-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-62589: extend test for grpc #62722
Conversation
Is there a better way to fix the
And how to pass it to the |
Maybe something like... ENV.prepend_path "PKG_CONFIG_PATH", Formula["[email protected]"].opt_lib/"pkgconfig" |
|
Yep, it really looks to me that these two versions (abseil and grpc) are incompatible. What do you guys think? What shell we do to this PR? |
First we need to have a test that breaks when the versions are incompatible. Currently it just seems like the grpc devs are bad at pkg-config. That could be a bug, but it wouldn't be in homebrew. After that we need to either have grpc fix it, or we need to rebuild on the homebrew side. |
Would it make sense to roll back the abseil version bump? (Before it was working fine.) It's a step back, but Homebrew would provide a good development experience. |
We're not rolling back the version unless upstream can tell us that these versions are fundamentally incompatible. So far we've only seen one bug report with 6,342 installs in the last 30 days. |
There is another one... #61866 (comment) Anyway, if you think I can help any of the action items, let me know. |
In that case it needs to be reported and patched upstream for sure. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Is there any way that this gets merged? I think it is improvement on the test coverage. |
The test is failing, so we're not going to merge it. Hopefully this is solved in future versions. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?@jonchang @SMillerDev can you help me out with this? (I can't test locally and no experience with ruby either.)
It's the change to extend the test coverage of
grpc
to usepkg-config
.