Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-62589: extend test for grpc #62722

Closed
wants to merge 1 commit into from
Closed

gh-62589: extend test for grpc #62722

wants to merge 1 commit into from

Conversation

rizsotto
Copy link

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@jonchang @SMillerDev can you help me out with this? (I can't test locally and no experience with ruby either.)

It's the change to extend the test coverage of grpc to use pkg-config.

@rizsotto
Copy link
Author

Is there a better way to fix the pkg-config for openssl than this?

PKG_CONFIG_PATH=/usr/local/opt/[email protected]/lib/pkgconfig

And how to pass it to the shell_output?

@jonchang
Copy link
Contributor

Maybe something like...

ENV.prepend_path "PKG_CONFIG_PATH", Formula["[email protected]"].opt_lib/"pkgconfig"

@SMillerDev
Copy link
Member

ld: library not found for -labsl_raw_hash_set

@rizsotto
Copy link
Author

Yep, it really looks to me that these two versions (abseil and grpc) are incompatible. What do you guys think? What shell we do to this PR?

@SMillerDev
Copy link
Member

First we need to have a test that breaks when the versions are incompatible. Currently it just seems like the grpc devs are bad at pkg-config. That could be a bug, but it wouldn't be in homebrew.

After that we need to either have grpc fix it, or we need to rebuild on the homebrew side.

@rizsotto
Copy link
Author

Would it make sense to roll back the abseil version bump? (Before it was working fine.) It's a step back, but Homebrew would provide a good development experience.

@SMillerDev
Copy link
Member

We're not rolling back the version unless upstream can tell us that these versions are fundamentally incompatible. So far we've only seen one bug report with 6,342 installs in the last 30 days.

@rizsotto
Copy link
Author

There is another one... #61866 (comment)

Anyway, if you think I can help any of the action items, let me know.

@SMillerDev
Copy link
Member

In that case it needs to be reported and patched upstream for sure.

@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Nov 26, 2020
@rizsotto
Copy link
Author

Is there any way that this gets merged? I think it is improvement on the test coverage.

@BrewTestBot BrewTestBot removed the stale No recent activity label Nov 27, 2020
@fxcoudert
Copy link
Member

Is there any way that this gets merged? I think it is improvement on the test coverage.

The test is failing, so we're not going to merge it. Hopefully this is solved in future versions.

@fxcoudert fxcoudert closed this Dec 16, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 16, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants