ripgrep 0.2.1 (new formula) #5268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😦 1 failing check, but when I click the link there are no failing checks. |
|
It failed on Sierra: |
|
@moshen: When you update this PR to pass tests on Sierra, you might as well update it to the just-released ripgrep 0.2.1 version as well. (^_^) |
moshen
force-pushed
the
new-formula-ripgrep
branch
from
5fdc9f5 to
ab43c5d
Compare
Is this related to: #4841 ? Specifically rust being in that list? |
|
BTW, there is a formula in the ripgrep repo itself which uses pre-built binaries. |
|
Looks like the rust issue was resolved for sierra in #4960 so the build may work now. |
|
Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
Have you built your formula locally prior to submission with
brew install <formula>(where<formula>is the name of the formula you're submitting)?Does your submission pass
brew audit --new-formula <formula>(after doingbrew install <formula>)?I can't because of "Error: type mismatch: String given" on brew audit --strict --online brew#1140Switched to master and was able to run audit.