Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot2docker: fixes #5264

Merged
merged 3 commits into from
Sep 26, 2016
Merged

boot2docker: fixes #5264

merged 3 commits into from
Sep 26, 2016

Conversation

DomT4
Copy link
Contributor

@DomT4 DomT4 commented Sep 26, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

@zmwangx zmwangx merged commit 96e5934 into Homebrew:master Sep 26, 2016
@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

Nice 👍 One more resolved in #4841.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

Um what did I just do... I'll add the bottle commit soon... (Guess I was too happy to try out the rebase and merge.)

@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

Bottle commit in f5a7d2a.

@DomT4
Copy link
Contributor Author

DomT4 commented Sep 26, 2016

😆 I thought you were going to forget to pull a bottle again for a moment there!

@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

Thanks to the hint in the title "Popular formulae with bottling trouble on 10.12", I didn't.

@DomT4
Copy link
Contributor Author

DomT4 commented Sep 26, 2016

Not having a ton of luck with Qt5 so far. The tip of the upstream 5.6, 5.7 and dev branches are all broken lol.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

Nice. /s

@DomT4
Copy link
Contributor Author

DomT4 commented Sep 26, 2016

Yeah. Looking like might have to try the tip of the 5.7 branch with some patches from the dev branch. Bunch o'fun.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

At this point you should just volunteer to be their release manager...

@DomT4
Copy link
Contributor Author

DomT4 commented Sep 26, 2016

Considering trying to slip someone at Qt a bribe to cut a working 5.7.1 tag today. Given we've refused to give up the pkg-config files for qt5 we might as well call it a fork at this point, heh.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants