valgrind: patch for Xcode 8 #4879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmwangx
added
xcode8
See: - http://valgrind.org/info/platforms.html (valgrind only supports 10.11 by 09/16/2016); - https://bugs.kde.org/show_bug.cgi?id=366138#c5.
zmwangx
force-pushed
the
valgrind-fix-xcode-8
branch
from
0ab9bcb to
c9df134
Compare
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install <formula>(where<formula>is the name of the formula you're submitting)?brew audit --new-formula <formula>(after doingbrew install <formula>)?Note: This PR currently contains another commit which is already in #4878. I just want to throw it out here and get some sleep. When I wake up the CI should have tested this, and I'll rebase and hopefully merge.
What's in this PR:
MaximumMacOSRequirementto El Cap. This is because Valgrind simply doesn't support Sierra at the moment, both seen from http://valgrind.org/info/platforms.html and a very recent dev comment (by the way, if my experience with Valgrind on OS X years ago still has any value, Valgrind is typically really slow at picking up new OS support, and even when the thing compiles, it's usually almost unusable until way later).