Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sops 3.4.0 #44191

Closed
wants to merge 1 commit into from
Closed

sops 3.4.0 #44191

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@alebcay alebcay added the build failure CI fails while building the software label Sep 13, 2019
@alebcay
Copy link
Member

alebcay commented Sep 13, 2019 

==> make install
GO15VENDOREXPERIMENT=1 GO111MODULE=on GOPROXY=https://proxy.golang.org go install go.mozilla.org/sops/cmd/sops
$GOPATH/go.mod exists but should not
make: *** [install] Error 1

@chenrui333 chenrui333 mentioned this pull request Sep 14, 2019
Closed
@wi1dcard
Copy link

Hi @chenrui333. Could you please change depends_on to [email protected] and make the build passed first? Looks like that updating Go 1.13 for sops requires a lot of work on it. They forked go-yaml into a new repo named mozilla-services/yaml which implemented Comment features for sops. Simply changing to gopkg.org/yaml.v2 won't work.

@chenrui333
Copy link
Member Author

yeah, that is good point, I will do that.

@chenrui333
Copy link
Member Author

Should be good now.

Yeah, sops go v1.13 upgrade is not quite straightforward.

@wi1dcard
Copy link

Thanks for your quick response!

@chenrui333
Copy link
Member Author

😄

@Moisan Moisan removed the build failure CI fails while building the software label Oct 2, 2019
@Moisan Moisan closed this in b2bb940 Oct 2, 2019
@ajvb ajvb mentioned this pull request Nov 6, 2019
Merged
@lock lock bot added the outdated PR was locked due to age label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@chenrui333 chenrui333 deleted the sops-3.4.0 branch December 18, 2022 04:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @alebcay @wi1dcard @Moisan