Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 10.2.0 #28200

Closed
wants to merge 1 commit into from
Closed

node 10.2.0 #28200

wants to merge 1 commit into from

Conversation

diogoazevedos
Copy link
Contributor

Created with brew bump-formula-pr.

@commitay commitay added the test failure CI fails while running the test-do block label May 24, 2018
@ilovezfs ilovezfs added the nodejs Node or npm use is a significant feature of the PR or issue label May 24, 2018
@ilovezfs
Copy link
Contributor

@chrmoritz any ideas?

@chrmoritz
Copy link
Contributor

gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
  /usr/bin/clang++ '-DNODE_GYP_MODULE_NAME=bufferutil' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_DARWIN_USE_64_BIT_INODE=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DBUILDING_NODE_EXTENSION' -I/tmp/node-test-20180524-59556-1tu9kmv/.node-gyp/10.2.0/include/node -I/tmp/node-test-20180524-59556-1tu9kmv/.node-gyp/10.2.0/src -I/tmp/node-test-20180524-59556-1tu9kmv/.node-gyp/10.2.0/deps/uv/include -I/tmp/node-test-20180524-59556-1tu9kmv/.node-gyp/10.2.0/deps/v8/include -I../../nan  -Os -gdwarf-2 -mmacosx-version-min=10.8 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF ./Release/.deps/Release/obj.target/bufferutil/src/bufferutil.o.d.raw -F/usr/local/Frameworks -Os -w -pipe -march=native -Xclang -target-feature -Xclang -aes -mmacosx-version-min=10.11 -c -o Release/obj.target/bufferutil/src/bufferutil.o ../src/bufferutil.cc
In file included from ../src/bufferutil.cc:7:
In file included from ../../nan/nan.h:51:
/tmp/node-test-20180524-59556-1tu9kmv/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: 'core.h' file not found
#include "core.h"  // NOLINT(build/include_order)
         ^
1 error generated.
make: *** [Release/obj.target/bufferutil/src/bufferutil.o] Error 1

It's caused by nodejs/node#20921, which should be fixed in the upcoming 10.2.1 release.

@ilovezfs
Copy link
Contributor

Thanks for finding that @chrmoritz

@chrmoritz
Copy link
Contributor

chrmoritz commented May 24, 2018

A fix for it landed upstream in nodejs/node@3f4caec. A new 10.2.1 release with it should follow shortly.

@diogoazevedos
Copy link
Contributor Author

Fixed in #28247

@diogoazevedos diogoazevedos deleted the node-10.2.0 branch May 24, 2018 20:18
@lock lock bot added the outdated PR was locked due to age label Jun 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants