Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

di: update livecheck #205956

Merged
merged 1 commit into from
Jan 30, 2025
Merged

di: update livecheck #205956

merged 1 commit into from
Jan 30, 2025

Conversation

samford
Copy link
Member

@samford samford commented Jan 30, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is a follow-up to #205859, as it was merged before I was able to review it.

The livecheck block for di was recently modified to check loose version text on the homepage, as the existing Sourceforge check was returning an unstable 4.99.5 version from the /beta subdirectory as newest. This addresses the issue by updating the previous Sourceforge check's regex to only target matching tarballs in the root directory.

The `livecheck` block for `di` was recently modified to check loose
version text on the homepage, as the existing `Sourceforge` check was
returning an unstable 4.99.5 version from the `/beta` subdirectory as
newest. This addresses the issue by updating the previous
`Sourceforge` check's regex to only target matching tarballs in the
root directory.
@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jan 30, 2025
@samford samford requested a review from chenrui333 January 30, 2025 00:17
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit bce29b5 Jan 30, 2025
17 checks passed
@BrewTestBot BrewTestBot deleted the di-update-livecheck branch January 30, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants