Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet@8 8.0.11 (new formula) #197537

Merged
merged 2 commits into from
Nov 16, 2024
Merged

dotnet@8 8.0.11 (new formula) #197537

merged 2 commits into from
Nov 16, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 13, 2024

Adding as versioned formula first to simplify #196479

Pulling in a few changes from that PR:

  • Use release.json manifest instead of git repo, which is usually faster and has better disk space handling in brew (git repos have 2 full copies while tarballs have the tar & one unpacked copy)
  • Try using macOS python
  • Try switch Linux to GCC as LLVM pulls in binutils that triggers some -fuse-ld= and avoids our shims.

@cho-m cho-m added the CI-skip-new-formulae Pass --skip-new to brew test-bot. label Nov 13, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core long build Set a long timeout for formula testing labels Nov 13, 2024
@cho-m cho-m added CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Nov 13, 2024
@cho-m cho-m mentioned this pull request Nov 13, 2024
5 tasks
@cho-m cho-m marked this pull request as ready for review November 13, 2024 06:42
@cho-m cho-m marked this pull request as draft November 14, 2024 14:42
@cho-m cho-m force-pushed the dotnet@8 branch 2 times, most recently from 27564b1 to 072bca2 Compare November 14, 2024 21:59
@cho-m
Copy link
Member Author

cho-m commented Nov 15, 2024

Going to skip the Intel Sonoma bottle given we have had issues with it after switching runner to Xcode 16.

Intel Ventura bottle seems okay when tested on Sequoia via Rosetta so at least should have a working bottle for about 1 year. Hopefully someone can figure out issue before we drop the Ventura runner.

@cho-m cho-m marked this pull request as ready for review November 15, 2024 18:23
@cho-m
Copy link
Member Author

cho-m commented Nov 15, 2024

Once Linux passes (may hit some sporadic failures), PR should be ready to merge. There are no dependents yet so can avoid having to run with CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests.

Can look further into 14-x86_64 problem later. First thing would be seeing if issue occurs in .NET 9.

EDIT: Copy of stack trace:

    Restored /private/tmp/sbom-tool-20241115-77419-8hyibf/sbom-tool-3.0.1/src/Microsoft.Sbom.Adapters/Microsoft.Sbom.Adapters.csproj (in 1.82 sec).
  Process terminated. Encountered infinite recursion while looking up resource 'Arg_ExternalException' in System.Private.CoreLib. Verify the installation of .NET is complete and does not need repairing, and that the state of the process has not become corrupted.
     at System.Environment.FailFast(System.String)
     at System.SR.InternalGetResourceString(System.String)
     at System.SR.GetResourceString(System.String)
     at System.Runtime.InteropServices.SEHException..ctor()
     at System.SR.InternalGetResourceString(System.String)
     at System.SR.GetResourceString(System.String)
     at System.Runtime.InteropServices.SEHException..ctor()
     at System.Collections.Concurrent.ConcurrentQueueSegment`1[[System.__Canon, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].TryEnqueue(System.__Canon)
     at System.Threading.ThreadPoolWorkQueue.Enqueue(System.Object, Boolean)
     at System.Threading.ThreadPool.UnsafeQueueUserWorkItem(System.Threading.IThreadPoolWorkItem, Boolean)
     at System.Net.Sockets.SocketAsyncEngine.EventLoop()
     at System.Threading.Thread.StartCallback()

@cho-m cho-m added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 15, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 16, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 16, 2024
Merged via the queue into master with commit aaa882e Nov 16, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the dotnet@8 branch November 16, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants