Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.42.3 #178375

Merged
merged 2 commits into from
Jul 25, 2024
Merged

dolt 1.42.3 #178375

merged 2 commits into from
Jul 25, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 8144: Don't panic when performing a GC on a shallow clone
  • 8143: Add support for visualizing prolly tree and blob messages in dolt show
    This PR does a couple things:
    1. dolt show #address can now display the internals of a ProllyTreeMap message (typically used for storing indexes). Previously, only splunk/noms show could do this.
    2. Both dolt show and splunk can now display the contents of a Blob message.
    3. If a ProllyTreeMap leaf node contains a value that is itself an address (example: the value of text and json columns), that value is shown as a human readable address, which can be fed back into dolt show or splunk to explore the whole tree.
  • 8141: support STAGED as commit hash
    This PR adds support for STAGED as a commit_hash when filtering dolt diff system tables.
    fixes for Should be able to use "STAGED" as commits in dolt_commit_diff_[tablename] dolthub/dolt#7978
  • 8140: Continue to support writes when archives are in play
    Error in hasMany effectively prevented writes after moving database to archives.
  • 8084: enable key range iter
    There was an issue merging [prolly] Float keyRange increment bug dolthub/dolt#8025 ontop of a revert. Enable the key iteration optimization.
  • 8072: [rowexec] dolt-side lookup execution operator
    This PR adds custom Dolt execution operators for lookup joins. When building an execution plan, we try to replace joinIter with a Dolt equivalent that inlines the key building and map get. This is a lot faster than repeatedly building the secondary iterator and materializing sql.Rows in-between lookups.
    The main downside is that this PR hoists filters in join children to after materializing lookup join rows.
    This brings index_join from 5.18 ms/query to 2.64 ms/q, which will be about 2.0x MySQL's latency.
    This PR falls short of some aspiration goals:
    • We hoist table filters until after the final join row is built because we don't have a way to call scalar expressions on val.Tuple yet. There are edge case queries that might be dramatically slower because of this. To fix this, we could need to convert sql.Expression filters into a format that we could execute on val.Tuple KV pairs.
    • We do not yet try to to optimize consecutive lookup joins. I'm not sure if a materialization block would be better represented iteratively or recursively beyond a simple string of lookups. A lot of interfaces and indexing considerations to think about there.
      Safety comments:
    • we fallback to GMS when lookup source/dest keys are not prolly.Encoding compatible
    • the source iterators are the same as what we used before, but without projection mapping to sql.Rows. The keyless iterator required a change to return duplicate rows at the KV layer (vs the sql layer).
    • the secondary iterators are a generalization of what we currently use, but return KV pairs instead of rows
    • projection mapping is the same but generalized to merge an arbitrary list of KV pairs after the join
      There are extra tests here: custom row exec dolthub/go-mysql-server#2593

go-mysql-server

Closed Issues

  • 8126: CREATE DATABASE statements should not create databases hierarchicaly
  • 7698: Incorrect return typefor UNIX_TIMESTAMP
  • 7978: Should be able to use "STAGED" as commits in dolt_commit_diff_[tablename]
  • 8131: Docker Mysql Server Resets When Connecting Immediately After Launch

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 25, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 25, 2024
@BrewTestBot BrewTestBot enabled auto-merge July 25, 2024 02:17
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 25, 2024
Merged via the queue into master with commit a724e6a Jul 25, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.42.3 branch July 25, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants