Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelogin 1.28.1 (new formula) #174211

Merged
merged 2 commits into from
Jun 14, 2024
Merged

kubelogin 1.28.1 (new formula) #174211

merged 2 commits into from
Jun 14, 2024

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented Jun 11, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 11, 2024
Formula/k/kubelogin.rb Outdated Show resolved Hide resolved
@rrotter rrotter marked this pull request as draft June 11, 2024 14:46
@rrotter rrotter marked this pull request as draft June 11, 2024 14:46
@rrotter rrotter force-pushed the kubelogin branch 3 times, most recently from c3e2c3d to db4beb4 Compare June 11, 2024 18:02
@rrotter rrotter marked this pull request as ready for review June 11, 2024 18:21
@rrotter
Copy link
Contributor Author

rrotter commented Jun 11, 2024

Added tests. Could skip the last one if we don't want to ping a 3rd party server. I hope the way I'm capturing the non-zero return status is acceptable. There's no way I'm aware of to do something useful with this tool and return zero without going through a full (successful) oauth login.

Formula/k/kubelogin.rb Outdated Show resolved Hide resolved
Formula/k/kubelogin.rb Outdated Show resolved Hide resolved
Formula/k/kubelogin.rb Outdated Show resolved Hide resolved
Formula/k/kubelogin.rb Outdated Show resolved Hide resolved
Formula/k/kubelogin.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 11, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 11, 2024
autobump: add kubelogin

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jun 14, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Jun 14, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 14, 2024
@chenrui333
Copy link
Member

@rrotter, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 14, 2024
@BrewTestBot BrewTestBot enabled auto-merge June 14, 2024 14:01
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 14, 2024
Merged via the queue into Homebrew:master with commit d0a1415 Jun 14, 2024
14 checks passed
@rrotter rrotter deleted the kubelogin branch June 15, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants