openai-whisper 20230314 #128276
openai-whisper 20230314 #128276
Conversation
github-actions
bot
added
python
| resource "more-itertools" do | ||
| url "https://files.pythonhosted.org/packages/13/b3/397aa9668da8b1f0c307bc474608653d46122ae0563d1d32f60e24fa0cbd/more-itertools-9.0.0.tar.gz" | ||
| sha256 "5a6257e40878ef0520b1803990e3e22303a41b5714006c32a3fd8304b26ea1ab" | ||
| resource "llvmlite" do |
There was a problem hiding this comment.
do you think we should have this as separate formula?
There was a problem hiding this comment.
Why? What's special about it, that it should be a separate formula? (I'm not discounting the idea, just curious.)
There was a problem hiding this comment.
nothing special (just curious), we do intend to extract resource into formula if possible. (but this can be totally done at a different time)
There was a problem hiding this comment.
It may make sense to provide numba as a separate formula, just like there are existing formulae for numpy, scipy, and cython. As I understand it, llvmlite is a dependency that is primarily used by numba, although it could in the future be used by other projects as well.
But since this is literally the first formula in homebrew-core that relies on numba, I figured it made sense to just leave it as a resource for now. It can be factored out into a formula if/when other formulae are introduced that can use it.
| def install | ||
| python3 = "python3.11" | ||
| venv = virtualenv_create(libexec, python3) | ||
| venv.pip_install resources.reject { |r| r.name == "test-audio" } | ||
| ENV["LLVM_CONFIG"] = Formula["llvm@14"].opt_bin/"llvm-config" |
There was a problem hiding this comment.
Is there any upstream issue tracker for supporting llvm@16?
There was a problem hiding this comment.
Looks like there's an issue for supporting LLVM 15, which I assume is a necessary step before the maintainers try to support LLVM 16.
github-actions
bot
added
the
CI-published-bottle-commits
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?