Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber: use upstream patch #106194

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

A version of the patch we use has been merged (google/libphonenumber@035901b), so let's switch to
using that one.

A version of the patch we use has been merged [1], so let's switch to
using that one.

[1] google/libphonenumber@035901b
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Jul 20, 2022
@BrewTestBot BrewTestBot added boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Jul 20, 2022
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@Bo98 Bo98 merged commit 3fb23ec into Homebrew:master Jul 20, 2022
@carlocab carlocab deleted the libphonenumber-patch branch July 20, 2022 14:01
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles icu4c ICU use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants