Add cuttle cask #10184
Merged
Add cuttle cask #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LesleyMdCampo looks like we need an empty line at the end of the file for the test to pass |
| version '1.1' | ||
| sha256 '7133beb24c3a37fe13f12d0b8110f1fcaf541d80e938cfaafb37a4d47bfcca15' | ||
|
|
||
| url 'https://github.com/oakmac/cuttle/releases/download/v1.1/cuttle-v1.1-mac.dmg' |
There was a problem hiding this comment.
Can you use #{version} here. i.e download/v#{version}/cuttle-v#{version}-mac.dmg
|
Once you've made the changes can you please also squash your commits? |
|
@fanquake - I'm not sure what the error in the Travis CI build is here. Can you help? |
| version '1.1' | ||
| sha256 '7133beb24c3a37fe13f12d0b8110f1fcaf541d80e938cfaafb37a4d47bfcca15' | ||
|
|
||
| url 'https://github.com/oakmac/cuttle/releases/download/v#{version}/cuttle-v#{version}-mac.dmg' |
There was a problem hiding this comment.
The error is here. You’re using interpolation (#{version}), so you need to use double quotes, or else it’s taking the whole string literally.
|
@LesleyMdCampo Thanks for updating, looks good now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.