Warn when using Xcode 8 without CLT on 10.11 #965
Conversation
mistydemeo
force-pushed
the
warn_xcode_8_without_clt
branch
from
b9aa004 to
235d03a
Compare
| @@ -90,6 +91,18 @@ def check_clt_up_to_date | |||
| EOS | |||
| end | |||
|
|
|||
| def check_xcode_8_without_clt_on_el_cap | |||
There was a problem hiding this comment.
Can we go for el_capitan here?
| return unless MacOS.version == :el_capitan && MacOS::Xcode.version >= "8" | ||
|
|
||
| <<-EOS.undent | ||
| You have Xcode 8 installed without the CLT; this causes certain builds to fail. |
There was a problem hiding this comment.
Worth spelling out this is El Capitan-only to avoid scaring Sierra people?
There was a problem hiding this comment.
The warning only prints on El Cap; are you worried about copy/pasted versions of it on the web being misinterpreted?
There was a problem hiding this comment.
Yeh, or people reading this message when they have a mixed environment and thinking it applies everywhere.
There was a problem hiding this comment.
Agreed it's probably best to explicitly mention El Cap. It'll only be a matter of time until someone sticks the message on stackoverflow or something without much context 🙈.
mistydemeo
force-pushed
the
warn_xcode_8_without_clt
branch
from
235d03a to
20da8f5
Compare
| <<-EOS.undent | ||
| You have Xcode 8 installed without the CLT; this causes certain builds to fail. | ||
| Please install the CLT via: | ||
| xcode-select --install |
There was a problem hiding this comment.
Maybe a good idea to recommend sudo here as xcode-select will only abort unless you give it elevated privs.
If we're using a vanilla non-sudo recommendation everywhere else though feel free to ignore me. No point introducing an inconsistency.
There was a problem hiding this comment.
It's totally inconsistent now I look at it - we have messages using both with and without. 😰 I'll update this now, and make a PR to update other messages for consistency later.
mistydemeo
force-pushed
the
warn_xcode_8_without_clt
branch
from
20da8f5 to
842881b
Compare
mistydemeo
force-pushed
the
warn_xcode_8_without_clt
branch
from
842881b to
8a0861f
Compare
|
@mistydemeo Is this still a problem? I'm wondering now the storm is over if it's worth reverting this. Alternatively, we wait until the 8.2 CLT on 10.11 (which is coming) and do it then. CC @ilovezfs who talked about this with me. |
brew testswith your changes locally?Xcode 8 on 10.11 has more issues than the usual mismatched SDK problems, and we're going to get a decent degree of breakage. I think it's important that
brew doctortell people to install the CLT in this case.It may be worth rethinking whether we want to support the Xcode-only-without-OS-specific-SDK usecase going forward. We've put a good amount of work into supporting Xcode-only over the years, but we're getting increasing amounts of pain for our efforts. I'd be happy to turn this PR into a blanket warn for that usecase, instead of something that only covers Xcode 8 on 10.11.
cc @DomT4