Skip to content

Commit

Permalink
Drop Clang 13 support, I don't want to debug the elusive warning it e…
Browse files Browse the repository at this point in the history
…mits.
  • Loading branch information
HolyBlackCat committed Dec 23, 2023
1 parent 4573b6d commit 22b10f5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ jobs:
run: git clone https://github.com/HolyBlackCat/macro_sequence_for ../macro_sequence_for
- name: List compilers
run: make -pq | grep ^COMPILER
- name: Confirm installed compilers
run: which clang++-17 clang++-16 clang++-15 clang++-14 clang++-13 g++-13 g++-12 g++-11 g++-10
- name: Run tests
run: make COMPILER='clang++-15 clang++-14 clang++-13 g++-12 g++-11 g++-10' CXXFLAGS='-Werror' CXXFLAGS_PER_COMPILER='clang++-13=-Wno-gnu-zero-variadic-macro-arguments'
run: make CXXFLAGS='-Werror'
Tests-MSVC:
runs-on: windows-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ std::copy_n(fib.begin(), 5, std::ostream_iterator<int>(std::cout, "\n")); // 5 8
Header-only. Just clone, add `include/` to the include path, and `#include <rcoro.hpp>`.
Supported compilers are: GCC 10+, Clang 13+, and the latest MSVC. Clang and GCC are recommended, since they're better at optimizing away the coroutine internals, with GCC being slightly behind.
Supported compilers are: GCC 10+, Clang 14+, and the latest MSVC. Clang and GCC are recommended, since they're better at optimizing away the coroutine internals, with GCC being slightly behind.
Must use C++20 or newer. MSVC users must use [`/Zc:preprocessor`](https://learn.microsoft.com/en-US/cpp/build/reference/zc-preprocessor?view=msvc-170).
Expand Down
12 changes: 3 additions & 9 deletions include/rcoro.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#endif

// The version number: `major*10000 + minor*100 + patch`.
#define RCORO_VERSION 204
#define RCORO_VERSION 205

// An assertion macro. If not customized, uses the standard `assert()`.
#ifndef RCORO_ASSERT
Expand Down Expand Up @@ -73,15 +73,9 @@
#endif
#endif

#ifndef RCORO_TEMPLATE_FRIEND
#if defined(__clang__)
// Silence a weird warning from Clang 13.
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-function"
#define RCORO_TEMPLATE_FRIEND(...) __VA_ARGS__
#pragma GCC diagnostic pop
#elif defined(__GNUC__)
// Silences GCC's silly `-Wnon-template-friend` warning.
#ifndef RCORO_TEMPLATE_FRIEND
#if defined(__GNUC__) && !defined(__clang__)
#define RCORO_TEMPLATE_FRIEND(...) \
_Pragma("GCC diagnostic push") \
_Pragma("GCC diagnostic ignored \"-Wnon-template-friend\"") \
Expand Down

0 comments on commit 22b10f5

Please sign in to comment.