Feature/jin dielectric sphere #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation is based on Jin's textbook. The notation used envisions already the implementation of the multi-layered sphere model, that is, we use a numbering, with the core sphere being numbered '1'. We test against a PMCHWT implementation via BEAST. Notable changes: - Excitation is now dependent on frequency instead of wavenumber: Frequency is always a real number, and the wavenumber can be computed from the embedding; - A sphere can be passed on to the excitation constructor, which correctly sets up the embedding; - Promote rules have been established to faciliate the usage of Medium; - Code unification for the plane wave part. In future, this will help to simplify code maintenance and debugging.
Testing of: - Medium - DielectricSphere - Planewave excitation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.