Make plane-wave excitation Jin compatible #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sticking to an implementation based on Ruck, we now follow Jin's notation. This change will help implementing a solution for dielectric problems, since Jin's book is much clearer on this As a side effect, the sign error is gone too now.
HoBeZwe
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Thank you, I think the changes are a good idea and look good.
However, before merging please also adapt the plane wave documentation: the wave is now travelling in positive z-direction and the scattered field computation now follows reference [1, p. x].
As a side note: I also did some tests locally at very low frequencies and everything looks fine.
HoBeZwe
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sticking to an implementation based on Ruck, we now follow Jin's notation.
This change will help implementing a solution for dielectric problems, since Jin's book is much clearer on this
As a side effect, the sign error is gone too now.