Workaround null-checks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin van Wingerden <[email protected]>
This was referenced Nov 8, 2018
Hilbrand
added a commit
that referenced
this pull request
Jul 8, 2020
* Removed plugName parameter It should not be a required parameter as it's not used to identify. So removed it as it's also already used to set the name. Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Simplified discovery code Changed to use serial number for smart plug thing id as is done with the other devices. Also some clean up of logging that were incorrect. Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Ran spotless to conform to styling Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Changed log message Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Added future to cancel scheduled command Signed-off-by: Hilbrand Bouwkamp <[email protected]>
andrew-schofield
pushed a commit
that referenced
this pull request
Jul 28, 2020
* Removed plugName parameter It should not be a required parameter as it's not used to identify. So removed it as it's also already used to set the name. Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Simplified discovery code Changed to use serial number for smart plug thing id as is done with the other devices. Also some clean up of logging that were incorrect. Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Ran spotless to conform to styling Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Changed log message Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Added future to cancel scheduled command Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand
pushed a commit
that referenced
this pull request
Dec 12, 2022
…penhab#13695) * [jsscripting] Refactor ThreadsafeTimers to create futures inline instead of in an extra methods * [jsscripting] Introduce utility class for providing easy access to script services * [jsscripting] Reimplement timer creation methods from ScriptExecution for thread-safety * [jsscripting] Add missing JavaDoc for reimplement timer creation methods * [jsscripting] Remove the future from the map when setTimeout expires * [jsscripting] Rename `GraalJSScriptServiceUtil` to `JSScriptServiceUtil` * [jsscripting] Remove the `createTimerWithArgument` method * [jsscripting] Replace the OSGi workaround of `JSScriptServiceUtil` with an injection mechanism * [jsscripting] Use constructor to inject `JSScriptServiceUtil` into `GraalJSScriptEngineFactory` * [jsscripting] Minor improvements by @J-N-K (#1) * [jsscripting] Minor changes related to last commit to keep flexibility of `JSRuntimeFeatures` * [jsscripting] Upgrade openhab-js to v2.1.1 * [jsscripting] Remove unused code Signed-off-by: Florian Hotze <[email protected]> Co-authored-by: Jan N. Klug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hilbrand @wborn