Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue 141 #231

Merged
merged 1 commit into from
Jul 1, 2020
Merged

fixed issue 141 #231

merged 1 commit into from
Jul 1, 2020

Conversation

VenkateshRavula
Copy link
Contributor

@VenkateshRavula VenkateshRavula commented Jun 30, 2020 •
edited
Loading

Description

Added fix to reset query parameters for every REST call.

Issues Resolved

Fixes #141

Check List

  • New functionality includes testing.
    • All tests pass for go 1.11 + gofmt checks.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

jyothisgm
jyothisgm approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@jyothisgm jyothisgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyothisgm
Copy link
Collaborator

You can close the issue once the PR is merged.

@VenkateshRavula VenkateshRavula merged commit 544059b into master Jul 1, 2020
@VenkateshRavula VenkateshRavula deleted the reset_query branch July 1, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chebroluharika chebroluharika chebroluharika approved these changes

@jyothisgm jyothisgm jyothisgm approved these changes

@AnushaY1916 AnushaY1916 Awaiting requested review from AnushaY1916

@nabhajit-ray nabhajit-ray Awaiting requested review from nabhajit-ray

@yuvirani yuvirani Awaiting requested review from yuvirani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query Parameter retains in the next endpoint call.
3 participants
@VenkateshRavula @jyothisgm @chebroluharika