fix: native runners detection in flatpak #53
Conversation
|
I started working on a fix for this before realizing you had a PR open. GOG games using DOSBox won't currently launch on Heroic 2.15.1 (latest release) if dosbox-staging is installed as a Flatpak. A mitigation in the meanwhile is to uninstall dosbox-staging, but that's an unobvious solution. It'd be great if we could get this merged and released. |
| if spawn_test.returncode == 0: | ||
| new_process_command = ["flatpak-spawn", "--host"] | ||
| process_command = new_process_command + process_command | ||
| try: |
There was a problem hiding this comment.
| try: | |
| # It's possible the current working directory is path from which we are unable to execute `flatpak-spawn`. | |
| # To ensure the command succeeds, switch to a known good path. | |
| os.chdir("/tmp") | |
| try: |
There was a problem hiding this comment.
After fixing the missing , in the "--host", "ls" argument list, I found I still had problems invoking flatpak-spawn. I logged stderr and what I got was:
Portal call failed: Failed to start command: Failed to change to directory "/run/flatpak/doc/c0447613" (No such file or directory)
The directory definitely exists within the sandbox. I'm unsure if there's a permissions issue preventing execution of arbitrary commands or if the --host option to flatpak-spawn requires a mapping that isn't permitted by the sandbox. I'm still fairly new to the Flatpak execution model. But, I found when I changed to /tmp, things worked fine. The path used is arbitrary, so feel free to change to something else if you'd like.
I'm not sure if you added FileNotFoundError handling for the same reason. If so, I think your handler will end up skipping the native dosbox-staging. The error handler will skip execution of the native dosbox-staging, so I think it's better if we can avoid hitting it when possible.
I did the chdir at this location so it would only be executed if we know we're running in an environment where flatpak-spawn should be used. We can move that, too, if needed -- I was trying to be conservative. I'm doing all of my testing on a sandoboxed Steam Deck with a custom built gogdl.
There was a problem hiding this comment.
I've confirmed that running the code in commit 77ecc22 fixes the crash but does not use the native dosbox-staging. In order to use dosbox-staging on my Steam Deck (i.e., with flatpak-spawn), the os.chdir line I suggested is needed.
There was a problem hiding this comment.
I just made a change. Though instead of static chdir to /tmp its done to game directory. That way if command still fails it suggests permission issue that would prevent the game from running nevertheless
There was a problem hiding this comment.
Oops. I guess I didn't post my comment. I had pulled your changes and built it again and it was all working. Thank you for the fix.
this should fix issues in flatpak where permissions to detect native runners aren't available