Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings with Xcode 14.0 #749

Merged
merged 2 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Transition/HeroTransition+Animate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import UIKit

extension HeroTransition {
open func animate() {
public func animate() {
guard state == .starting else { return }
state = .animating

Expand Down
2 changes: 1 addition & 1 deletion Sources/Transition/HeroTransition+Complete.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import UIKit

extension HeroTransition {
open func complete(finished: Bool) {
public func complete(finished: Bool) {
if state == .notified {
forceFinishing = finished
}
Expand Down
6 changes: 3 additions & 3 deletions Sources/Transition/HeroTransition+Start.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import UIKit

extension HeroTransition {
open func start() {
public func start() {
guard state == .notified else { return }
state = .starting

Expand Down Expand Up @@ -163,11 +163,11 @@ extension HeroTransition {
processors.forEach {
$0.process(fromViews: context.fromViews, toViews: context.toViews)
}

animatingFromViews = context.fromViews.filter { (view: UIView) -> Bool in
animators.contains { $0.canAnimate(view: view, appearing: false) }
}

animatingToViews = context.toViews.filter { (view: UIView) -> Bool in
animators.contains { $0.canAnimate(view: view, appearing: true) }
}
Expand Down