Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Linkvertise #10

Closed
wants to merge 32 commits into from
Closed

support Linkvertise #10

wants to merge 32 commits into from

Conversation

8MiYile
Copy link

@8MiYile 8MiYile commented Apr 21, 2023 •
edited
Loading

Solve #9

@8MiYile 8MiYile changed the title re upload these commit re upload these commit and support Linkvertise Apr 21, 2023
@8MiYile 8MiYile mentioned this pull request Apr 21, 2023
Open
HeroCC
HeroCC requested changes May 4, 2023
View reviewed changes
Copy link
Owner

@HeroCC HeroCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks good functionally, just a few other misc changes. I made comments throughout.

@8MiYile
Copy link
Author

8MiYile commented May 4, 2023 •
edited
Loading

Are you still there?
I thought you had left your project

@HeroCC
Copy link
Owner

HeroCC commented May 4, 2023

Are you still there? I thought you had left your project

I'm still around. The plugin is generally stable and I don't use YOURLS daily anymore, so I don't make many updates here. But, I still am happy to accept PRs and do some maintenance in my free time.

@8MiYile
Copy link
Author

8MiYile commented May 5, 2023

Okay, please recheck. If the changes pass, I'll push the user configuration piece along with it

@8MiYile
Copy link
Author

8MiYile commented May 5, 2023

Next Update is
image

@8MiYile 8MiYile changed the title re upload these commit and support Linkvertise support Linkvertise May 5, 2023
@8MiYile 8MiYile deleted the branch HeroCC:master December 2, 2023 09:17
@8MiYile 8MiYile closed this Dec 2, 2023
@8MiYile 8MiYile deleted the master branch December 2, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeroCC HeroCC HeroCC requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8MiYile @HeroCC