implement ičo and vatin quests

[vfosnar]

help wanted: you can work on this if you're interested in finishing this PR, see #669 (comment)

I used place_name quest as a template, I'm not sure if the element selection is okay and if it shouldn't be refactored in some way

• https://wiki.openstreetmap.org/wiki/Key:ref:ico - it's a company identifier in Czech Republic and Slovakia
• https://wiki.openstreetmap.org/wiki/Key:ref:vatin

[vfosnar]

relevant discussion in StreetComplete repo streetcomplete#5933

[mnalis]

I think it should be made separate list, curated for the features that are actually likely to have ref:vatin / ref:ico signed. I mean, it seems very unlikely to me that landuse=cemetery or military=barracks and military=training_area would each have their own ref:vatin, for example!

Better start with smaller list to avoid a lot of places where it less likely that VATIN would be signed... It can always be extended later...

So, if the lists are same for both ref:vatin and ref:ico, I'd create a new list (e.g. var VATIN_PLACES = mapOf(....), put it in separate file (in same directory as the quests) and the import it in both quests; to avoid duplication and ease updating of the list in the future (if needed).

[Helium314]

The quests should be limited to countries where they (reasonably) apply, i.e. CZ and SK for IČO, and EU and some more for vatin (here it also depends how easy it's to find, be it from outside or on receipts).

Further, same as for contact quests, I do not want to push (nearly) unused *:signed=no tags.

(I'm also not happy about very country-specific quests of low importance, as I fear this will invite other people wanting to add such quests... While a few are fine (we also have the SC postbox cypher quest), this has potential to evolve into a huge list, making quest selection hard to use.)

[mnalis]

The quests should be limited to countries where they (reasonably) apply, i.e. CZ and SK for IČO, and EU and some more for vatin (here it also depends how easy it's to find, be it from outside or on receipts).

That one is easy @vfosnar; just search for enabledInCountries = NoCountriesExcept and use https://ent8r.github.io/blacklistr/ if needed to get country codes.

Further, same as for contact quests, I do not want to push (nearly) unused *:signed=no tags.

Yeah, I tend to agree. Even if *:signed prefix is defined, we should try not to spam it with newly invented values; especially in quests where it is not critical for using the data (like here).
So, I'd guess, just remove option to add *:signed=no, and have users hide the quest for themselves where unanswerable...

(I'm also not happy about very country-specific quests of low importance, as I fear this will invite other people wanting to add such quests... While a few are fine (we also have the SC postbox cypher quest), this has potential to evolve into a huge list, making quest selection hard to use.)

Agreed. ref:vatin at least is little wider so should be fine anyway, and I think we can accept the other one too for now. If more of such localized quests requests arise, we can set more firm inclusion criteria then... So far it does not seem like too problematic to me...

Re: [This branch has conflicts that must be resolved]

Also I note conflicts in app/src/main/res/values-cs/strings.xml - that file should be removed, non-English translations are handled separately from PR...

[Helium314]

and I think we can accept the other one too for now

Certainly.
But at the same time if a bunch of people is trying to add such quests I smell the "but you allowed this other quest" style of arguing we see evey time in SC with the power pole material quest.

Also I note conflicts in app/src/main/res/values-cs/strings.xml - that file should be removed, non-English translations are handled separately from PR...

Yes, SC strings should ideally not be touched (only strings_ee).

[vfosnar]

Sorry for leaving this PR dead, school got in the way and I lost motivation to continue developing. Implementing this quest is not my priority rn even though it shouldn't be hard to finish it. I'll leave the PR to others who wish to finish it atl for now.

[Helium314]

I'll leave the PR to others who wish to finish it atl for now.

If you agree, I would open the PR again and add a "help wanted" label. This way it's more visible, and I'd close it in case someone is interested in working on this.