Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added saddle_holder for bicycle_parking quest #652

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

mcliquid
Copy link

The bike park season is almost over, but I think it's still relevant :)

mnalis

This comment was marked as resolved.

@mcliquid
Copy link
Author

Nice, although a different picture would be better if available.

@mnalis Do you have a suggestion?

@mnalis
Copy link
Collaborator

mnalis commented Sep 16, 2024

@mnalis Do you have a suggestion?

@mnalis

This comment was marked as outdated.

@mcliquid
Copy link
Author

@mnalis The latest images from my camera roll you can find here: https://commons.wikimedia.org/w/index.php?title=Special:ListFiles/Mcliquid&ilshowall=1

@mnalis
Copy link
Collaborator

mnalis commented Sep 17, 2024

that https://commons.wikimedia.org/wiki/File:Fahrradparkplatz_Sattelhalter_1.jpg looks like it would be discernible on small screens the best IMHO

@mcliquid
Copy link
Author

Perfect match! Changed it already here: 3aaa1a4

Copy link
Collaborator

@mnalis mnalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you tested that it works, this looks good to me!

@Helium314
Copy link
Owner

Looks fine, thanks!

@Helium314 Helium314 merged commit 8b89a43 into Helium314:modified Sep 19, 2024
@Helium314
Copy link
Owner

Oh, I noticed you added the string to SC strings, not SCEE. No real problem, but it won't be translatable in Weblate.

@mcliquid
Copy link
Author

Thanks! I will update them.

@mcliquid mcliquid deleted the bicycle_parking-saddle_holder branch September 19, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants