Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge all SCEE ref quests into one #532

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

FloEdelmann
Copy link

@FloEdelmann FloEdelmann commented Apr 6, 2024

Fixes #531. Since #529 has not been released yet, removing it should not be a problem.

For reviewing, it makes sense to go through each commit one-by-one, since diffs are displayed for renamed files then.

subway entrances, substation buildings, street cabinets and street lamps
reference numbers are often, well, numbers, or uppercase single letters

see https://taginfo.openstreetmap.org/keys/ref#values
@Helium314
Copy link
Owner

Thanks, I think this is fine.
I didn't test, but I assume the filter works correctly? Asking because I'm not sure about evaluation of "a or b and c or d and e" style without parentheses.

@qugebert are you ok with this modification / removal of the guidepost ref quest?

@FloEdelmann
Copy link
Author

I assume the filter works correctly?

Yes, I tested it.

I'm not sure about evaluation of "a or b and c or d and e" style without parentheses

and takes precedence over or, so this is correct. This is also how other quests do it:

or amenity = grit_bin and seasonal = no
or amenity = vending_machine and vending ~ parking_tickets|public_transport_tickets

... and Tobias prefers this style, as less parentheses is less visual clutter to parse mentally.

@qugebert
Copy link

qugebert commented Apr 9, 2024

@qugebert are you ok with this modification / removal of the guidepost ref quest?

Yes

@Helium314 Helium314 merged commit 6496611 into Helium314:modified Apr 9, 2024
@FloEdelmann FloEdelmann deleted the general-ref branch April 9, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Street furniture ref quest
3 participants