Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 Basic Auth fix #19

Merged
merged 3 commits into from
Jan 29, 2025
Merged

#13 Basic Auth fix #19

merged 3 commits into from
Jan 29, 2025

Conversation

beforan
Copy link
Member

@beforan beforan commented Jan 29, 2025

Pull Request Contents

🦋 Bug Fix

Description

This PR resolves the Basic Auth issue when attempting to authorize Collection/SubNode actions for a given user.

Related Issues or other material

  • This PR relates to one or more issues, detailed below

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

  • This PR contains relevant tests
    • Or doesn't need to per the below explanation

[optional] What gif best describes this PR or how it makes you feel?

programmer falls in a bug hole

  • I've completed all actions and tasks detailed in the PR Template

dcl10
dcl10 previously approved these changes Jan 29, 2025
Copy link

@dcl10 dcl10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ I may be misremembering, but I think in the logging statements, there's an alternate syntax like LogInformation("Some variable {variable}", variable) and C# liked that better for it being computed at compile time? But not enough for me to request the change lol

@beforan
Copy link
Member Author

beforan commented Jan 29, 2025

⛏️ I may be misremembering, but I think in the logging statements, there's an alternate syntax like LogInformation("Some variable {variable}", variable) and C# liked that better for it being computed at compile time? But not enough for me to request the change lol

This is 100% correct, I've been through the BasicAuthHandler's logging calls and sorted it.

@beforan beforan merged commit 40caf3b into main Jan 29, 2025
3 checks passed
@beforan beforan deleted the auth-fix branch January 29, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relay - Basic Auth handler compares the username against the wrong value, so always fails
3 participants