Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Dockerfile #80

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Improved Dockerfile #80

merged 3 commits into from
Feb 13, 2025

Conversation

beforan
Copy link
Member

@beforan beforan commented Feb 13, 2025

Pull Request Contents

🦋 Bug Fix
⚡️ Optimization
🛠️ Repo maintenance

Description

Improves our published docker images:

  • Multistage Dockerfile gives cleaner final container environment
    • also about 100mb smaller
  • non-editable app package installation makes final container runtime environment better
  • more professional running bunny app entrypoints directly (not via uv run)
  • change from ENTRYPOINT to default CMD retains prior default behaviour (bunny-daemon) but allows more flexible CLI usage
    • Makes the image more compatible with certain execution environments, e.g. CWL, Bacalhau...

This PR includes a version bump so that we can immediately get newly version tagged releases for the new images.

Related Issues or other material

  • This PR relates to one or more issues, detailed below

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

  • This PR contains relevant tests
    • Or doesn't need to per the below explanation

No code changes

[optional] What gif best describes this PR or how it makes you feel?

Docker whale

  • I've completed all actions and tasks detailed in the PR Template

@beforan beforan merged commit cb363a5 into main Feb 13, 2025
5 checks passed
@beforan beforan deleted the alt-dockerfile branch February 13, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container image / CLI improvements
2 participants