Add basic MSSQL support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Contents
✨ Feature
Description
Adds support for MS SQL Server using the default
pymssqldriver.Similar to postgresql a user may define the environment variable
DATASOURCE_DB_DRIVERNAMEin an unqualified way i.e.mssqlor may also define in fullmssql+pymssqlConnection arguments have been left as an option to be passed to
SyncDBManagerRelated Issues or other material
This PR relates to one or more issues, detailed below
Closes SQLServer Support #2
✅ Added/updated tests?
This PR does not add any additional tests.
The adjusted code has however been tested externally for operation with Azure SQL and Azure Postgresql