Update nom to 7.0.0 #102
Merged
Update nom to 7.0.0 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
approved these changes
Oct 24, 2021
|
Ah, it's because CI isn't running since we moved the repo into the HdrHistogram org. I'll get on fixing that in #103. In the meantime, let me give running the tests for this CR a shot. |
|
Checked that tests pass locally, so merging! |
|
Released as 7.4.0 🎉 |
|
Awesome thanks 🎉 and yeah as long as you weren't using nom macros or anything moved to another crate (bitvec/regex) the 6->7 upgrade is often that simple 😁 |
|
No, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Nom 6 used a version of bitvec using the old (and bad) way of ignoring code via tarpaulin
#[cfg_attr(tarpaulin,skip)], unfortunately having this in a users dependency tree means you need to use an older version of tarpaulin or run--avoid-cfg-tarpaulinand limits a users ability to filter out code in coverage runs.This PR updates nom to 7.0.0, it would also be nice for affected tarpaulin users if there could be a new hdrhistogram release after this is merged 🙏
Some other benefits mentioned in the nom changelog, faster float parsing, better compile times, and slimmer dependencies as bitvec and regex code are moved into separate nom crates to further reduce binary size and compilation time.