Don't undefine __STRICT_ANSI__ for mingw #1112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done originally for #785. However, since gcc 11.1.0, this gives a warning:
This is due to this change: https://gcc.gnu.org/git/?p=gcc.git;a=commit;f=libstdc%2B%2B-v3/include/bits/c%2B%2Bconfig;h=767537a8b027bcb5807bb45b0268c5da98c2c7a0
The original problem in #785 doesn't happen with mingw-w64. The original mingw project is outdated (and 32 bit only) so it is safe remove this flag now. Compilation with the original mingw is already broken anyway:
Mingw compilation errors
``` Error: D:/hxcpp/src/hx/Thread.cpp:628:2: error: 'CONDITION_VARIABLE' does not name a type CONDITION_VARIABLE cond; ^ D:/hxcpp/src/hx/Thread.cpp: In constructor 'hxCondition::hxCondition()': D:/hxcpp/src/hx/Thread.cpp:641:31: error: 'cond' was not declared in this scope InitializeConditionVariable(&cond); ^ D:/hxcpp/src/hx/Thread.cpp:641:35: error: 'InitializeConditionVariable' was not declared in this scope InitializeConditionVariable(&cond); ^ D:/hxcpp/src/hx/Thread.cpp: In member function 'void hxCondition::Wait()': D:/hxcpp/src/hx/Thread.cpp:711:30: error: 'cond' was not declared in this scope SleepConditionVariableCS(&cond,&cs,INFINITE); ^ D:/hxcpp/src/hx/Thread.cpp:711:47: error: 'SleepConditionVariableCS' was not declared in this scope SleepConditionVariableCS(&cond,&cs,INFINITE); ^ D:/hxcpp/src/hx/Thread.cpp: In member function 'bool hxCondition::TimedWait(double)': D:/hxcpp/src/hx/Thread.cpp:721:43: error: 'cond' was not declared in this scope return (bool)SleepConditionVariableCS(&cond, &cs, (DWORD)((FLOAT)timeout * 1000.0)); ^ D:/hxcpp/src/hx/Thread.cpp:721:86: error: 'SleepConditionVariableCS' was not declared in this scope return (bool)SleepConditionVariableCS(&cond, &cs, (DWORD)((FLOAT)timeout * 1000.0)); ^ D:/hxcpp/src/hx/Thread.cpp: In member function 'void hxCondition::Signal()': D:/hxcpp/src/hx/Thread.cpp:744:27: error: 'cond' was not declared in this scope WakeConditionVariable(&cond); ^ D:/hxcpp/src/hx/Thread.cpp:744:31: error: 'WakeConditionVariable' was not declared in this scope WakeConditionVariable(&cond); ^ D:/hxcpp/src/hx/Thread.cpp: In member function 'void hxCondition::Broadcast()': D:/hxcpp/src/hx/Thread.cpp:753:30: error: 'cond' was not declared in this scope WakeAllConditionVariable(&cond); ^ D:/hxcpp/src/hx/Thread.cpp:753:34: error: 'WakeAllConditionVariable' was not declared in this scope WakeAllConditionVariable(&cond); ```