Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support @:using on typedefs #9749

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

vonagam
Copy link
Member

@vonagam vonagam commented Jul 25, 2020

Builds on #9682.
Related issues - #9681, #8188, #7859.

@vonagam vonagam force-pushed the using-on-typedef branch 2 times, most recently from dc856f9 to 75f4827 Compare July 25, 2020 20:59
@skial skial mentioned this pull request Jul 27, 2020
1 task
@vonagam vonagam force-pushed the using-on-typedef branch 4 times, most recently from 1856810 to d7b4854 Compare July 28, 2020 16:14
@vonagam vonagam force-pushed the using-on-typedef branch from d7b4854 to c1c1b45 Compare July 28, 2020 18:19
@Simn Simn merged commit 8fe9ba6 into HaxeFoundation:development Jul 29, 2020
@kLabz
Copy link
Contributor

kLabz commented Jul 29, 2020

Hmm, this broke my application with @:build on typedef is not allowed errors somehow

Edit: could come from addGlobalMetadata:

Macro.hx

class Macro {
	public static function build() {
		return haxe.macro.Context.getBuildFields();
	}
}

build.hxml

--js index.js
--macro "addGlobalMetadata('js', '@:build(Macro.build())')"

jdonaldson pushed a commit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants