Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @:using for interfaces and abstracts #8310

Merged
merged 4 commits into from
May 22, 2019
Merged

Fix @:using for interfaces and abstracts #8310

merged 4 commits into from
May 22, 2019

Conversation

RealyUniqueName
Copy link
Member

@RealyUniqueName RealyUniqueName commented May 20, 2019 •
edited
Loading

@RealyUniqueName RealyUniqueName added this to the Release 4.0 milestone May 20, 2019
@RealyUniqueName RealyUniqueName requested a review from Simn May 20, 2019 08:02
@RealyUniqueName RealyUniqueName marked this pull request as ready for review May 20, 2019 10:31
@skial skial mentioned this pull request May 20, 2019
Closed
1 task
@RealyUniqueName
Copy link
Member Author

@Simn ready for review

Simn
Simn reviewed May 22, 2019
View reviewed changes
@Gama11
Copy link
Member

Gama11 commented May 22, 2019

Since the title says "for interfaces and abstracts", I take it the verdict is to not support it for typedefs / structures?

In that case, can we have a compiler error when trying to use the meta there?

@RealyUniqueName
Copy link
Member Author

Actually, I forgot, we need to decide on typedefs :)
I'm ok with any option - either allow or prohibit @:using on typedefs.
@Simn @ncannasse ?

@Simn
Copy link
Member

Simn commented May 22, 2019

Can we worry about that later and merge this first?

@RealyUniqueName RealyUniqueName merged commit 2d978c8 into HaxeFoundation:development May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simn Simn Simn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RealyUniqueName @Gama11 @Simn