Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to luv 0.5.13 #11761

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update to luv 0.5.13 #11761

merged 1 commit into from
Sep 10, 2024

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Sep 4, 2024

Closes #11575

@skial skial mentioned this pull request Sep 5, 2024
Closed
1 task
@olafhering
Copy link

olafhering commented Sep 6, 2024 •
edited
Loading

Please consider 0.5.14 instead: ocaml/opam-repository#26501
0.5.13 and older is broken, fails to compile with GCC 14, and should be avoided.

@tobil4sk
Copy link
Member Author

tobil4sk commented Sep 6, 2024

The version is specified as "luv" {>= "0.5.13"} so it is still possible to use 0.5.14 or any newer version. 0.5.13 is the minimum version required for compatibility in terms of ocaml code in haxe.

@Simn Simn merged commit 526e57c into HaxeFoundation:development Sep 10, 2024
50 checks passed
@tobil4sk tobil4sk deleted the luv-0.5.13 branch September 10, 2024 14:31
@kLabz
Copy link
Contributor

kLabz commented Sep 10, 2024

Uh. This broke my env, and macos-14 CI 🤔

@Simn
Copy link
Member

Simn commented Sep 10, 2024

Huh, but CI was green...

@tobil4sk tobil4sk mentioned this pull request Sep 10, 2024
Merged
@tobil4sk tobil4sk mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

luv 0.5.13 broke our Windows builds again
4 participants
@tobil4sk @olafhering @kLabz @Simn